Skip to content

[AutoPR] servicefabric/data-plane#3002

Merged
lmazuel merged 3 commits intomasterfrom
restapi_auto_servicefabric/data-plane
Jul 31, 2018
Merged

[AutoPR] servicefabric/data-plane#3002
lmazuel merged 3 commits intomasterfrom
restapi_auto_servicefabric/data-plane

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Jul 25, 2018

Created to accumulate context: servicefabric/data-plane

@AutorestCI
Generated from 8842b69926229d7097ef82a5c333ced9fcaa06dc (#2981)
fed031f 
ensure the correct case is used for the Resource folder in referencing the examples
@AutorestCI AutorestCI requested a review from samedder as a code owner July 25, 2018 18:17
This was referenced Jul 25, 2018
Merged
Merged
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jul 25, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-servicefabric

You can install the package azure-servicefabric of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_servicefabric/data-plane#egg=azure-servicefabric&subdirectory=azure-servicefabric"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_servicefabric/data-plane#egg=azure-servicefabric&subdirectory=azure-servicefabric"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_servicefabric/data-plane
  • pip install -e ./azure-servicefabric

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_servicefabric/data-plane
  • pip wheel --no-deps ./azure-servicefabric

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Jul 25, 2018 •
edited
Loading

Codecov Report

Merging #3002 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
+ Coverage   56.35%   56.41%   +0.05%     
==========================================
  Files        8124     8201      +77     
  Lines      166280   167590    +1310     
==========================================
+ Hits        93713    94542     +829     
- Misses      72567    73048     +481
Impacted Files Coverage Δ
...azure/mgmt/keyvault/key_vault_management_client.py 80% <0%> (-20%) ⬇️
...8_02_01_preview/models/operation_definition_py3.py 38.46% <0%> (-18.69%) ⬇️
...v2018_02_01_preview/models/operation_definition.py 38.46% <0%> (-18.69%) ⬇️
...try/v2017_10_01/models/operation_definition_py3.py 38.46% <0%> (-18.69%) ⬇️
...egistry/v2017_10_01/models/operation_definition.py 38.46% <0%> (-18.69%) ⬇️
...ry/v2017_10_01/operations/registries_operations.py 69.18% <0%> (-11.05%) ⬇️
..._02_01_preview/operations/registries_operations.py 77.14% <0%> (-5.23%) ⬇️
...dels/container_registry_management_client_enums.py 100% <0%> (ø) ⬆️
...t/containerregistry/v2017_10_01/models/__init__.py 100% <0%> (ø) ⬆️
...nerregistry/v2018_02_01_preview/models/__init__.py 100% <0%> (ø) ⬆️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed1e22...503eac1. Read the comment docs.

@AutorestCI AutorestCI mentioned this pull request Jul 27, 2018
Merged
10 tasks
@AutorestCI
Generated from b9a3d8f42ed43d826d45af0ae6c88b871546302e (#3021)
210d374 
Remove newline characters from the description property value. These extra characters are resulting in extra "." dot character in the python_sdk.
@AutorestCI AutorestCI mentioned this pull request Jul 27, 2018
Merged
@Christina-Kang
Copy link

Christina-Kang commented Jul 27, 2018 •
edited
Loading

Created PR to update change log here: #3024

Please hold off on PR view. Need to update to include python 3.7. Thanks!

Update: PR changes are completed. @samedder can you review please. Thank you

@Christina-Kang @lmazuel
Add in notes for 6.3.0.0 release (#3024)
503eac1 
* Add in notes for 6.3.0.0 release

* include python 3.7
@samedder
Copy link
Contributor

samedder commented Jul 31, 2018

Looks good

@Christina-Kang
Copy link

Christina-Kang commented Jul 31, 2018

@lmazuel Can you take a look and then merge and release the SDK please? Thank you! :)

lmazuel
lmazuel approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lmazuel lmazuel merged commit e4049b3 into master Jul 31, 2018
@lmazuel lmazuel deleted the restapi_auto_servicefabric/data-plane branch July 31, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

@samedder samedder samedder approved these changes

Assignees

No one assigned

Labels

ServicePR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AutorestCI @codecov-io @Christina-Kang @samedder @lmazuel